Axosoft / nsfw

A super fast and scaleable file watcher that provides a consistent interface on Linux, OSX and Windows
MIT License
901 stars 113 forks source link

Crash when deleting folder #169

Closed gdavidkov closed 1 year ago

gdavidkov commented 1 year ago

Hello, We are using the package within the Electron application. The OS is Windows 10 Scenario: When the folder is deleted but the Windows OS dialog "Folder Access Denied" appears. Always reproducible. The dialog: nsfw_callstack_2 Stacktrace: image

julianmesa-gitkraken commented 1 year ago

@gdavidkov Can you check if this PR fix your issue?

gdavidkov commented 1 year ago

Sure. I will check and keep you posted.


From: Julian Mesa @.> Sent: Friday, November 18, 2022 3:02:15 PM To: Axosoft/nsfw @.> Cc: Georgi Davidkov @.>; Mention @.> Subject: Re: [Axosoft/nsfw] Crash when deleting folder (Issue #169)

@gdavidkovhttps://github.com/gdavidkov Can you check if this PR fix your issue?

— Reply to this email directly, view it on GitHubhttps://github.com/Axosoft/nsfw/issues/169#issuecomment-1319965708, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABML34T6ODP5ATYRVF2YMCLWI545PANCNFSM6AAAAAARZEFBYE. You are receiving this because you were mentioned.Message ID: @.***>

gdavidkov commented 1 year ago

It works. I've received the following error: Service shutdown: root path changed (renamed or deleted)

julianmesa-gitkraken commented 1 year ago

It works. I've received the following error: Service shutdown: root path changed (renamed or deleted)

Great. I will try to get the PR merged ASAP. Thks for testing.

julianmesa-gitkraken commented 1 year ago

Fixed in PR170