Axway-API-Management-Plus / dynatrace-apim-oneagent

Axway APIM Dynatrace APM integration
Apache License 2.0
8 stars 1 forks source link

Changing behaviour in handling timeout errors #21

Closed gcornacchia closed 12 months ago

gcornacchia commented 1 year ago

Hi, We've found a strange behavior in handling timeout errors in a gateway policy calling a backend endpoint. Consider the following versions:

Axway API Gateway version: 7.7 nov 2021 Dynatrace-apim-oneagent version: branch Nov2021

With Dynatrace agent on:

image

The connect to URL exits with a false value

image

The same package, In another environment without Dynatrace agent:

image

After the connect to url the fault handler is invoked.

image

So it seems that dynatrace-apim-oneagent is changing the behavior by changing the exception and changing the policy flow.

What do you think?

rathnapandi commented 1 year ago

Hi @gcornacchia,

I made changes to handle the exception. Can you checkout the latest code from Nov 2021 branch and test it?

gcornacchia commented 12 months ago

hi @rathnapandi, our tests with patched libraries gave us a positive outcome.

Thanks

gcornacchia commented 12 months ago

hi @rathnapandi just a question about the lifecycle of this component, I don't see tags or released packages, moreover there are different branches for compatibility with different Axway versions. This patch you just made is it already merged into the main branch? I'm thinking that "tomorrow" when we update to a newer API gateway version we need also to update also these libraries....

rathnapandi commented 12 months ago

Hi @gcornacchia, We are creating a branch whenever there is incompatibility with old api gateway libraries. We can introduce tags and no plans to do release as it uses API gateway internal libraries which blocks creating CI / CD pipeline.

I am waiting for your response to merge the changes to the main branch. will do it shortly.

Thanks Rathna

rathnapandi commented 12 months ago

Changes merged with main branch.

Thanks Rathna