search

Ayagikei / LifeUp

Pure and highly customizable gamified to-do and habit-forming app.
209 stars 4 forks source link

[Bug] Achievements with an API call as the only condition always show 0% #103

Open UsernamesAreNotMyThing opened 1 year ago

UsernamesAreNotMyThing commented 1 year ago

Describe the bug Achievements that have an API call as the only condition always appear as 0% in the list, regardless of actual progress.

Expected behavior The displayed percentage should reflect the progress on the API call condition.

Screenshots Screenshot_20231016-125959

Environments and Version (please complete the following information):

Ayagikei commented 1 year ago

Thanks for the feedback!

We will look into it asap.

Ayagikei commented 1 year ago

Hello, I tried to use the item to test the API, but could not reproduce the problem.

We need to confirm, are you using an external tool such as Tasker to call the API?

v1.93.0-rc02 We checked the relevant code and found that there is logic at the code level to update the overall achievement progress. But it and updating the progress of a single condition belong to two processes and are executed by a dedicated single thread. Then fixed an issue that could cause progress calculation errors.

We're not sure yet whether this is caused by single-thread blocking or something else.

UsernamesAreNotMyThing commented 1 year ago

Yes, this problem is specifically with the External API Call condition when "running" it from automation apps like Tasker.