ccpcheck failures against Debian testing (2022-09-09)

[sunweaver]

    Start 1: cppcheck

1/6 Test #1: cppcheck .........................***Failed    0.23 sec

Checking /rootdir/src/adbd-client.cpp ...

1/20 files checked 13% done

Checking /rootdir/src/exporter.cpp ...

/rootdir/src/exporter.cpp:84:16: style: Variable 'profile' can be declared as reference to const [constVariable]

    for (auto& profile : m_indicator->profiles())

               ^

2/20 files checked 21% done

Checking /rootdir/src/greeter.cpp ...

3/20 files checked 29% done

Checking /rootdir/src/indicator.cpp ...

4/20 files checked 31% done

Checking /rootdir/src/main.cpp ...

5/20 files checked 35% done

Checking /rootdir/src/rotation-lock.cpp ...

6/20 files checked 44% done

Checking /rootdir/src/usb-manager.cpp ...

7/20 files checked 52% done

Checking /rootdir/src/usb-monitor.cpp ...

8/20 files checked 55% done

Checking /rootdir/src/usb-snap.cpp ...

9/20 files checked 67% done

Checking /rootdir/tests/integration/usb-manager-test.cpp ...

10/20 files checked 79% done

Checking /rootdir/tests/integration/usb-manager-test_autogen/mocs_compilation.cpp ...

11/20 files checked 80% done

Checking /rootdir/tests/unit/adbd-client-test.cpp ...

/rootdir/tests/unit/adbd-client-test.cpp:59:7: style: Variable 'tests' can be declared as const array [constVariable]

    } tests[] = {

      ^

12/20 files checked 84% done

Checking /rootdir/tests/unit/adbd-client-test_autogen/mocs_compilation.cpp ...

13/20 files checked 84% done

Checking /rootdir/tests/unit/greeter-test.cpp ...

14/20 files checked 90% done

Checking /rootdir/tests/unit/greeter-test_autogen/mocs_compilation.cpp ...

15/20 files checked 90% done

Checking /rootdir/tests/unit/rotation-lock-test.cpp ...

16/20 files checked 92% done

Checking /rootdir/tests/unit/rotation-lock-test_autogen/mocs_compilation.cpp ...

17/20 files checked 93% done

Checking /rootdir/tests/unit/usb-snap-test.cpp ...

/rootdir/tests/unit/usb-snap-test.cpp:71:7: style: Variable 'tests' can be declared as const array [constVariable]

    } tests[] = {

      ^

18/20 files checked 99% done

Checking /rootdir/tests/unit/usb-snap-test_autogen/mocs_compilation.cpp ...

19/20 files checked 99% done

Checking /rootdir/tests/utils/test-utils_autogen/mocs_compilation.cpp ...

20/20 files checked 100% done

/rootdir/tests/unit/greeter-test_autogen/mocs_compilation.cpp:3:0: style: The function 'cmake_automoc_silence_linker_warning0c25854c7576357606a2b7b73219535f82274b49dc0db807a2660312f182d4f9' is never used. [unusedFunction]

^

/rootdir/tests/integration/usb-manager-test_autogen/mocs_compilation.cpp:3:0: style: The function 'cmake_automoc_silence_linker_warning107119aa6ee141ce137285ae10cc26832eaf4044b5196646409b26f2452d9559' is never used. [unusedFunction]

^

/rootdir/tests/utils/test-utils_autogen/mocs_compilation.cpp:3:0: style: The function 'cmake_automoc_silence_linker_warningb8fe5310a4816440f521adf67f74bd17a1f5bdd999ab535e362e6e12cff5947a' is never used. [unusedFunction]

^

/rootdir/tests/unit/adbd-client-test_autogen/mocs_compilation.cpp:3:0: style: The function 'cmake_automoc_silence_linker_warningc6033ff3ee2a079862151fcf22e6db689c2db8481b50b8f02fb2910b1014eb6c' is never used. [unusedFunction]

^

/rootdir/tests/unit/rotation-lock-test_autogen/mocs_compilation.cpp:3:0: style: The function 'cmake_automoc_silence_linker_warningd8e5a3ddeb1c6c2817eb01d5d8708e970215be2f32b1f9baa4a48e1a7665b112' is never used. [unusedFunction]

^

/rootdir/tests/unit/usb-snap-test_autogen/mocs_compilation.cpp:3:0: style: The function 'cmake_automoc_silence_linker_warninge022c632bf7bf7a5354c0fdbe021e2f2101d829a22672666c7a5a9a1998449e2' is never used. [unusedFunction]

^

[JamiKettunen]

Any progress? I'm also seeing these test failures on Void Linux with tagged release 22.9.0. Should I send patches?

[sunweaver]

@JamiKettunen Please do. Thanks.