search

AyatanaIndicators / ayatana-indicator-display

Ayatana Indicator Display
GNU General Public License v3.0
2 stars 7 forks source link

Hide redshifting/brightness slider, if not support by Xserver / driver #70

Closed sunweaver closed 4 months ago

sunweaver commented 1 year ago

I just tested the new redshift feature of the display indicator in X2Go's nxagent. Nothing happens there. So we should not show the redshifting controls on nxagent.

Similar in a KVM VM (both Spice/VNC backends, graphical drivers: QXL / virtio). No redshifting happens when moving the slider.

I will log out of my local machine's session now and test MATE desktop (not my daily driver) to see if it works there.

sunweaver commented 1 year ago

Redshifting does not work, when Xserver runs in a qemu/KVM instance (xrandr shows Virtual-X as output)

Redshifting does not work in X2Go session (check with RDA?)

@tari01 any opinion on this?

tari01 commented 1 year ago

Redshifting does not work, when Xserver runs in a qemu/KVM instance (xrandr shows Virtual-X as output)

Redshifting does not work in X2Go session (check with RDA?)

@tari01 any opinion on this?

I'm not really familiar with the internals of a virtual X, but perhaps it would be good to open an issue against xsct, and fall back on libRda detection as a last resort...

tari01 commented 5 months ago

@sunweaver: I did some research into how we could detect a virtual environment. virt-what would be perfect, but it needs root so it's out. Using libxrandr with some string parsing can give us what we need. Are we okay with adding libxrandr as a dependency only for this?

sunweaver commented 5 months ago

@sunweaver: I did some research into how we could detect a virtual environment. virt-what would be perfect, but it needs root so it's out. Using libxrandr with some string parsing can give us what we need. Are we okay with adding libxrandr as a dependency only for this?

Yes, sure.

sunweaver commented 5 months ago

xrandr on the command line provides the needed info, as well.