search

AyatanaIndicators / ayatana-indicator-display

Ayatana Indicator Display
GNU General Public License v3.0
2 stars 7 forks source link

Hide adaptive modes (theme, brightness/redshift) if geoclue-2.0 DBus service is not available #95

Open sunweaver opened 6 months ago

sunweaver commented 6 months ago

If there is not geoclue-2.0 provider on the DBus session bus, hide the adaptive modes in display indicator.

tari01 commented 4 months ago

I don't think we need to do this: the indicator has a fallback longitude/latitude which can be tweaked in GSettings.

sunweaver commented 4 months ago

I don't think we need to do this: the indicator has a fallback longitude/latitude which can be tweaked in GSettings.

Please hide those menu items if they cannot be used. Note that the customer's target system is an enterprise desktop. Showing features that don't exist is no option there.

tari01 commented 4 months ago

I don't think we need to do this: the indicator has a fallback longitude/latitude which can be tweaked in GSettings.

Please hide those menu items if they cannot be used. Note that the customer's target system is an enterprise desktop. Showing features that don't exist is no option there.

But that's exactly my point: those features do exist and can be used even without geoclue.

sunweaver commented 4 months ago

So, for clarification:

For the enterprise Linux, we want:

The enterprise desktop won't have geoclue running and in that case, the following menu items should be invisible/hidden:

The adaptive seems to be alluding auto-leveling those well you by some information (time of day, timezone, location, time of year).

Are you saying that the auto-leveling works if we simply roll-out geo coordinates via GSettings?

sunweaver commented 4 months ago

If so, we should be able to allow the user to adjust those geo-coordinates. (We must assume that they go travelling from time to time).

sunweaver commented 4 months ago

However, this might be beyond the scope of a display indicator. In fact, we have white papers for a location indicator. There this would be a nice feature to land.

Not sure how to handle this for now, though.

tari01 commented 4 months ago

Are you saying that the auto-leveling works if we simply roll-out geo coordinates via GSettings?

Yes. I have written it so that it never crashes regardless of the geolocation state. It starts up with the last coordinates stored in GSettings (Greenwich by default) and updates them if geoclue becomes available. If geoclue times out, it stays as-is.