search

AyatanaIndicators / ayatana-indicator-keyboard

Ayatana Indicator Keyboard Applet
GNU General Public License v3.0
2 stars 6 forks source link

src/keyboard-lomiri.c: Add as much functionality to Lomiri as currently possible #32

Closed tari01 closed 2 years ago

tari01 commented 2 years ago

This will need rebasing to build.

sunweaver commented 2 years ago

I have rebased this PR's update branch now (it now includes code from PR #31).

tari01 commented 2 years ago

This PR looks like a big chunk of code duplication. Can't we handle this better?

All the TODOs will most likely be different in Lomiri. Until we find out what exactly Lomiri will provide for accessing the X display and the layouts, I would like to keep it this way. It's very easy to expand and compare to the X library. Once the Lomiri library gets all the functionality that the X library has, I would look into simplifying the code (with a bit of luck we might even end up using libklavier in Lomiri, in which case I would merge all and drop the library approach.