search

AyatanaIndicators / ayatana-indicator-keyboard

Ayatana Indicator Keyboard Applet
GNU General Public License v3.0
2 stars 6 forks source link

src/service.c: Use 'input-keyboard' (symbolic) icon as indicator icon on Lomiri. #37

Closed sunweaver closed 2 years ago

sunweaver commented 2 years ago

@tari01 That's the intention. At least on Lomiri, the current language icon looks rather clumsy. I will test this patch in MATE tomorrow and I assume that the keyboard icon will be more beautiful there, as well. The current keyboard should be highlighted when opening the indicator's menu.

tari01 commented 2 years ago

@tari01 That's the intention. At least on Lomiri, the current language icon looks rather clumsy. I will test this patch in MATE tomorrow and I assume that the keyboard icon will be more beautiful there, as well. The current keyboard should be highlighted when opening the indicator's menu.

We could then do this conditionally for Lomiri, but on desktop people would need an easy way to see what the active layout is. I would not like to click around to find it out. I normally use 4 layouts, and switch by pressing CTRL+CTRL, which is instantly shown by the icon.

sunweaver commented 2 years ago

Maybe make this configurable through gsettings for MATE et al?

sunweaver commented 2 years ago

@tari01 See updated PR branch.

sunweaver commented 2 years ago

@tari01 Your proposed change doesn't seem to work, e.g. gchar *sLanguage is declared in the else clause whereas it gets used in the upper if clause part. Why do we need sLanguage stuff in both if-and-else-clauses?

tari01 commented 2 years ago

@tari01 Your proposed change doesn't seem to work, e.g. gchar *sLanguage is declared in the else clause whereas it gets used in the upper if clause part. Why do we need sLanguage stuff in both if-and-else-clauses?

Aaagh, sorry. Copy-paste error. Just drop the m_fnKeyboardGetLayout line from upper part.