AyatanaIndicators / ayatana-indicator-sound

Ayatana Indicator Sound Applet
GNU General Public License v3.0
2 stars 7 forks source link

Pr/replace x canonical attributes #10

Closed tari01 closed 4 years ago

tari01 commented 4 years ago

This looks seriously messed up. I hope the new commit properly overwrites the previous one. Going to lie down and stare at the ceiling now...

sunweaver commented 4 years ago

@tari01: this PR looked weird. I reworked it entirely. It felt like you renamed those attributes that should not be renamed and left those that we uses solely in AI. Except from the x-ayatana-type. Those were renamed correctly. Please take a look at the reworked commit that I just force-pushed to your PR branch. Thanks.

sunweaver commented 4 years ago

Make sure you pull/fetch the PR branch from Github with "--force"... Or rename the branch locally first (git branch -m " and then fetch the PR branch from Github with the new commit I remastered.

tari01 commented 4 years ago

Yep. Pulled, checked. It looks decent now. Thanks.