search

AyatanaIndicators / ayatana-indicator-sound

Ayatana Indicator Sound Applet
GNU General Public License v3.0
2 stars 7 forks source link

Enable all notification tests on Lomiri #31

Closed tari01 closed 3 years ago

tari01 commented 3 years ago
tari01 commented 3 years ago

Hmmm... with this, you are not unit-testing anything in Lomiri really. This adjustment only makes sense if you run the test twice, once with XDG_CURRENT_DESKTOP set to Lomiri (or some such) and once without. May guess is that our tests run without XDG_CURRENT_DESKTOP being set to anything.

As the notification-test.cc files does not use the Lomiri API for notifications directly, but a mock provided via notification-mock.h instead, the proper solution would probably be to repair the mock part of this test.

With the patch provided by this PR, we allude to the tests working ok, but what the test does is simply returning in the second line of test code. Not optimal.

Please resolve or postpone.

I discovered that these can be run on a Lomiri live system (SEGFAULTs everywhere else), hence the PR. It basically does what it's supposed to do - ignores the tests unless you are on a real Lomiri.

Since this is a hack, I'm OK if we simply close it. Doing it.