search

AyatanaIndicators / ayatana-indicator-sound

Ayatana Indicator Sound Applet
GNU General Public License v3.0
2 stars 7 forks source link

FTBFS on focal (due to missing liblomiri-api-dev) #59

Closed sunweaver closed 2 years ago

sunweaver commented 2 years ago

@tari01 The current main branch fails to CI-build, because gmenuharness needs lomiri-api as a build-dependency. This all fails on Travis CI for Ubuntu 20.04 currently.

Two strategies:

  1. Don't build/run the gmenuharness based tests during builds/tests on focal
  2. Also build lomiri-api from source before building gmenuharness for CI builds

Opinions?

tari01 commented 2 years ago

@tari01 The current main branch fails to CI-build, because gmenuharness needs lomiri-api as a build-dependency. This all fails on Travis CI for Ubuntu 20.04 currently.

Two strategies:

1. Don't build/run the gmenuharness based tests during builds/tests on focal

2. Also build lomiri-api from source before building gmenuharness for CI builds

Opinions?

We added Ubuntu builds only because the Ubuntu-specific dependencies. Since we don't use those anymore, I think it's safe to skip testing on Ubuntu and rely on the Debian results. I would eventually go further and drop Ubuntu builds entirely (they will only become a CI overhead).

sunweaver commented 2 years ago

Well, I'd like to be prepared for Ubuntu 20.04 breakages when Ayatana Indicators get pulled over to Ubuntu Touch 20.04. This is my main reason for doing the Ubuntu 20.04 CI builds. So, in this respect, we'd rather should continue with having them around. Don't you think?

tari01 commented 2 years ago

Well, I'd like to be prepared for Ubuntu 20.04 breakages when Ayatana Indicators get pulled over to Ubuntu Touch 20.04. This is my main reason for doing the Ubuntu 20.04 CI builds. So, in this respect, we'd rather should continue with having them around. Don't you think?

Definitely keep Ubuntu during the transition. I would conditionally build gmenuharness for Debian only, though.