search

AyatanaIndicators / libayatana-appindicator

Ayatana Application Indicators Shared Library
GNU Lesser General Public License v3.0
56 stars 13 forks source link

Fix build warnings #59

Closed tari01 closed 1 year ago

tari01 commented 2 years ago

fixes https://github.com/AyatanaIndicators/libayatana-appindicator/issues/24

@sunweaver I would like to have this merged and continue fixing it in a later pull request to avoid making a mess.

tari01 commented 2 years ago

I don't see the point in renaming APP_IS_INDICATOR / IS_APP_INDICATOR. Personally, it seems that IS_APP_INDICATOR is the better phrase anyway.

We will certainly break API with this, so we should not have this renaming, IMHO.

This is the proper name of the macro when creating GObject C subclasses, it's internal to the class. Somebody mistakenly swapped the IS_ part a long time ago. The build also complains about it.

https://wiki.gnome.org/HowDoI/SubclassGObject

While we have IS_APP_INDICATOR, we must consider the code malformed and broken. It's a miracle the other macros only throw warnings.