AyeshaIkhlas21 / dealing-with-whitespace

Spend some time looking spacing in typography: margins, paddings, line-length, line-height, etc.
0 stars 0 forks source link

Dealing with whitespace problem #1

Open AyeshaIkhlas21 opened 3 years ago

AyeshaIkhlas21 commented 3 years ago

Hi, I have a problem.

Screen Shot 2021-03-22 at 12 46 19 PM

@carolsinc

carolsinc commented 3 years ago

You need to target the padding on your article. If you don't set it yourself, there is automatic padding on it.

AyeshaIkhlas21 commented 3 years ago

I tried it but not working. How do the article header move little up ? Margin-top: 0?

carolsinc commented 3 years ago

Margin and padding are different. Targeting margin will not effect padding. Did you try setting the padding on article to 0?

AyeshaIkhlas21 commented 3 years ago

Yes. Still not working :(

carolsinc commented 3 years ago

Did you commit it? It's not showing up on my end

AyeshaIkhlas21 commented 3 years ago
Screen Shot 2021-03-23 at 5 43 59 PM

Markbot said screenshots 16%

carolsinc commented 3 years ago

on article h1 you did margin-bottom: 0; so you still have a margin on top. if you just to margin: 0; it will take them both off at the same time

AyeshaIkhlas21 commented 3 years ago

So close. Marbot says screenshot - 19% I have no idea. What is going on?

carolsinc commented 3 years ago

There are other places where you have used margin-top or margin-bottom where they both need to be targeted

AyeshaIkhlas21 commented 3 years ago

I did. but still 19%

carolsinc commented 3 years ago

In the top left corner of markbot there is an eye icon. Click that to open your website in a browser. right click in the browser and you will get a dropdown menu. Click inspect. This will open your code in the browser. When you hover over your html elements in your code you can see your padding and margins, I think that will help a lot.

AyeshaIkhlas21 commented 3 years ago
Screen Shot 2021-03-23 at 6 24 38 PM

Click Advanced?

carolsinc commented 3 years ago

yes, because GitHub is open source they are not secure websites

carolsinc commented 3 years ago

Were you able to complete the assignment?

AyeshaIkhlas21 commented 3 years ago

Yes. I did it. Thank you

carolsinc commented 3 years ago

Awesome!