search

AykutSarac / jsoncrack-vscode

VS Code extension of JSON Crack. Convert your JSON files into graphs with a single click and view them onto graphs.
https://marketplace.visualstudio.com/items?itemName=AykutSarac.jsoncrack-vscode
MIT License
407 stars 45 forks source link

[BUG]: Extension doesnt show icon for .jsonc files. #36

Open WybeBosch opened 1 year ago

WybeBosch commented 1 year ago

Issue description

The extension doesnt detect .jsonc as a file it should show the icon for. Its still possible to open it manually via the command panel command, and the extension works properly for .jsonc files aswell.

Seems this could be impemented by adding .jsonc as a file extension for the icon check. And maybe in future we could have support for showing the comments inside the visualizer aswell as this other issue suggested. https://github.com/AykutSarac/jsoncrack-vscode/issues/30

Operating system

Priority this issue should have

Low (slightly annoying)

de-dan commented 5 months ago

Would be fantastic if .json5 (json5.org/) documents also gets in consideration. Looking at the npm weekly downloads, this standard has a quite significant user base.