Aylur / ags

A customizable and extensible shell
GNU General Public License v3.0
1.75k stars 94 forks source link

Setting Stream.stream.is_muted has no effect #365

Closed ttoino closed 3 months ago

ttoino commented 3 months ago

When using the audio service, setting the is_muted property on the wrapped stream object (directly or through set_is_muted) has no effect on whether the stream is muted, although it does change the property value. Interestingly, calling change_is_muted does work.

Example:

const audio = await Service.import("audio");

audio.speaker.stream.is_muted = true; // Changes the property to true, but sound keeps playing
audio.speaker.stream?.set_is_muted(true); // Same as above
audio.speaker.stream?.change_is_muted(true); // Actually mutes the speaker
SwollenBadger commented 3 months ago

(com.github.Aylur.ags:301324): Gvc-CRITICAL **: 17:25:16.439: gvc_mixer_card_get_index: assertion 'GVC_IS_MIXER_CARD (card)' failed

i don't know if that log related, but i'm facing same issue

Aylur commented 3 months ago

for whatever reason I always glanced over change_is_muted and never realized it was a thing

97 did result in some confusion, but this will work now as expected