Aylur / ags

A customizable and extensible shell
GNU General Public License v3.0
2.11k stars 109 forks source link

Neovim? #369

Closed rafaeljacov closed 6 months ago

rafaeljacov commented 6 months ago

image

I have run "ags --init" but LSP still doesn't know it I'm using tsserver for my LSP

h-banii commented 6 months ago

hmm from the screenshot it seems that the types symlink is missing. It should've been created automatically by the command ags --init, but apparently it didn't...

I just tested it on Arch, ags v1.8.0 (AUR), and tsserver LSP on neovim seems to be working. image

So the problem is likely on ags --init not creating the symlink correctly in your case, not neovim.

OBS.: If you open that README file it'll tell you where the symlink was supposed to point to, it might be different if you're using nix image

rafaeljacov commented 6 months ago

hmm from the screenshot it seems that the types symlink is missing. It should've been created automatically by the command ags --init, but apparently it didn't...

I just tested it on Arch, ags v1.8.0 (AUR), and tsserver LSP on neovim seems to be working. image

So the problem is likely on ags --init not creating the symlink correctly in your case, not neovim.

OBS.: If you open that README file it'll tell you where the symlink was supposed to point to, it might be different if you're using nix image

Strange, I ran ls command and it shows in the shell that the symlink does exist, but doesn't show on NvimTree. Another strange thing is that it shows the symlink as a file and not a directory

image

EDIT: Just checked and saw that the real file in the symlink doesn't exist, ran ags --init again and still the same case. I'm thinking I did not install it correctly. I compiled it manually and did the instructions given image

DO I NEED TO RUN post_install.sh?

h-banii commented 6 months ago

@rafaeljacov

Ah I see, try turning on the "build_types" option when building with meson, like this:

meson setup build --wipe -Dbuild_types=true
meson install -C build

I just tested it on fedora and it should probably work for you as well (hopefully).

Alternatively, you can set the build_types option in the meson_options.txt file (it's set to false by default).

EDIT: I'm almost certain meson already runs the post_install.sh script, so you probably don't need to do that.

rafaeljacov commented 6 months ago

@rafaeljacov

Ah I see, try turning on the "build_types" option when building with meson, like this:

meson setup build --wipe -Dbuild_types=true
meson install -C build

I just tested it on fedora and it should probably work for you as well (hopefully).

Alternatively, you can set the build_types option in the meson_options.txt file (it's set to false by default).

EDIT: I'm almost certain meson already runs the post_install.sh script, so you probably don't need to do that.

I get this at the end of compilation even if the tsc command is available on my shell (I'm using fish but manually switching to bash still recognizes the command without any problem):

Running custom install script '/usr/bin/env bash /home/rafaeljacov/ags/post_install.sh /usr/local/share /usr/local/share/com.github.Aylur.ags /usr/local/bin com.github.Aylur.ags true /home/rafaeljacov/ags'
/home/rafaeljacov/ags/post_install.sh: line 23: tsc: command not found

Running which tsc outputs:

/home/rafaeljacov/.local/share/nvm/v21.7.1/bin/tsc
h-banii commented 6 months ago

Usually nvm requires updating the PATH through .profile or .bashrc, so I guess meson doesn't source those files when running the installation.

There are a few different ways to fix that error in your specific case:

Or this fix that should work anywhere:

Not sure if I should open a PR for that branch, I believe it's a neat solution, but for the time being I'll just link it here just in case there are other people with global npm installations or custom installations of tsc.

rafaeljacov commented 6 months ago

Yes I also thought it would just be better to use the local tsc instead. I just fixed my problem by referencing the full path to my tsc. Thanks

rydymth commented 6 months ago

Alternatively, you can set the build_types option in the meson_options.txt file (it's set to false by default).

Thnkyou @h-banii! Editing the meson-options.txt worked for me!