Aylur / ags

A customizable and extensible shell
GNU General Public License v3.0
1.73k stars 94 forks source link

Hyprland service inconsistencies #433

Closed Nanderty closed 4 weeks ago

Nanderty commented 1 month ago

Hey Aylur, thank you for making ags, I really enjoy it!

While the Hyprland signals, especially monitor and workspace return the name of the added/removed monitor/workspace, the getMonitor and getWorkspace methods expect the Hyprland id of the monitor/workspace. Wouldn't it be better to have both the methods and the signals use either the id or the name? I would suggest using the name, since, especially concerning the monitors, referencing the connector is much more intuitive.

Aylur commented 4 weeks ago

iirc thats because at the time when it was written, Hyprland itself was inconsistent, for example hyprctl workspaces did not include monitorID They will stay as is for now, to not break backwards compatibility. Although once I port service implementations to Vala, I'll try to be more consistent