Aylur / astal

Building blocks for creating custom desktop shells
https://aylur.github.io/astal/
GNU Lesser General Public License v2.1
279 stars 35 forks source link

Cava build fails on latest nixpkgs-nightly #100

Closed Suyashtnt closed 1 week ago

Suyashtnt commented 1 week ago

Describe the bug AstalCava's internal cava build fails on nix with the following log output:

autoreconf: export WARNINGS=
autoreconf: Entering directory '.'
autoreconf: configure.ac: not using Gettext
autoreconf: running: aclocal --force -I m4
aclocal: warning: couldn't open directory 'm4': No such file or directory
configure.ac:306: error: _AX_CHECK_GL_MANUAL_LIBS_GENERIC: argument must not be empty
lib/m4sugar/m4sh.m4:690: _AS_IF_ELSE is expanded from...
lib/m4sugar/m4sh.m4:697: AS_IF is expanded from...
/nix/store/fvdsb9i4vb8ca77s8lh60cil33m36dmk-autoconf-archive-2024.10.16/share/aclocal/ax_check_gl.m4:187: _AX_CHECK_GL_MANUAL_LIBS_GENERIC is expanded from...
lib/m4sugar/m4sh.m4:595: AS_CASE is expanded from...
/nix/store/fvdsb9i4vb8ca77s8lh60cil33m36dmk-autoconf-archive-2024.10.16/share/aclocal/ax_check_gl.m4:253: AX_CHECK_GL is expanded from...
lib/m4sugar/m4sh.m4:697: AS_IF is expanded from...
lib/m4sugar/m4sh.m4:697: AS_IF is expanded from...
configure.ac:306: the top level
autom4te: error: /nix/store/ab13djpkv4pyii8lvz4106bimy62db59-gnum4-1.4.19/bin/m4 failed with exit status: 1
aclocal: error: /nix/store/wky99hgy2w2nb3a6hzgk96yqdbi95zsj-autoconf-2.72/bin/autom4te failed with exit status: 1
autoreconf: error: aclocal failed with exit status: 1

To Reproduce use the following flake.nix:

{
  description = "astal with latest nixpkgs";

  inputs = {
    nixpkgs.url = "github:NixOS/nixpkgs/nixpkgs-unstable";

    flake-utils.url = "github:numtide/flake-utils";

    astal = {
      url = "github:aylur/astal";
      inputs.nixpkgs.follows = "nixpkgs";
    };
  };

  outputs = {
    nixpkgs,
    flake-utils,
    astal,
    ...
  }: {
    packages = astal.packages;
  };
}

and run nix build .#cava

it'll then error

Expected behavior It should build the cava package successfully

Additional context exact flake.lock:

{
  "nodes": {
    "astal": {
      "inputs": {
        "nixpkgs": [
          "nixpkgs"
        ]
      },
      "locked": {
        "lastModified": 1731772019,
        "narHash": "sha256-2yr5U56rzzfdzhuUA2kb5Fc4GPBBQWz9gqwrEfv0PX4=",
        "owner": "aylur",
        "repo": "astal",
        "rev": "5c7e82b561ec7fda2df463ad12a2b72d59a720a2",
        "type": "github"
      },
      "original": {
        "owner": "aylur",
        "repo": "astal",
        "type": "github"
      }
    },
    "flake-utils": {
      "inputs": {
        "systems": "systems"
      },
      "locked": {
        "lastModified": 1731533236,
        "narHash": "sha256-l0KFg5HjrsfsO/JpG+r7fRrqm12kzFHyUHqHCVpMMbI=",
        "owner": "numtide",
        "repo": "flake-utils",
        "rev": "11707dc2f618dd54ca8739b309ec4fc024de578b",
        "type": "github"
      },
      "original": {
        "owner": "numtide",
        "repo": "flake-utils",
        "type": "github"
      }
    },
    "nixpkgs": {
      "locked": {
        "lastModified": 1731763621,
        "narHash": "sha256-ddcX4lQL0X05AYkrkV2LMFgGdRvgap7Ho8kgon3iWZk=",
        "owner": "NixOS",
        "repo": "nixpkgs",
        "rev": "c69a9bffbecde46b4b939465422ddc59493d3e4d",
        "type": "github"
      },
      "original": {
        "owner": "NixOS",
        "ref": "nixpkgs-unstable",
        "repo": "nixpkgs",
        "type": "github"
      }
    },
    "root": {
      "inputs": {
        "astal": "astal",
        "flake-utils": "flake-utils",
        "nixpkgs": "nixpkgs"
      }
    },
    "systems": {
      "locked": {
        "lastModified": 1681028828,
        "narHash": "sha256-Vy1rq5AaRuLzOxct8nz4T6wlgyUR7zLU309k9mBC768=",
        "owner": "nix-systems",
        "repo": "default",
        "rev": "da67096a3b9bf56a91d16901293e51ba5b49a27e",
        "type": "github"
      },
      "original": {
        "owner": "nix-systems",
        "repo": "default",
        "type": "github"
      }
    }
  },
  "root": "root",
  "version": 7
}
shadeyg56 commented 1 week ago

This was fixed in nixpkgs

https://github.com/NixOS/nixpkgs/pull/355948

It's just waiting to pass Hydra tests