search

Aymkdn / html-to-pdfmake

This module permits to convert HTML to the PDFMake format
https://aymkdn.github.io/html-to-pdfmake/index.html
MIT License
545 stars 88 forks source link

Feature/proxy #183

Closed nerdess closed 1 year ago

nerdess commented 1 year ago

Adding an optional option imagesByReferenceProxy to be able to define a proxy url to fetch images in order to prevent CORS issues.

Aymkdn commented 1 year ago

Thanks for sharing, however you added some other stuff that are specific to you (like removing the blue color on links). When you submit a pull request you should limit it to the feature you want to add.

Also, for the image proxy, it sounds better to use the data-src on the img instead.

For example:

<img src="https://server/img.png" data-src="https://proxyserver/?image=https%3A%2F%2Fserver%2Fimg.png" />