search

Aymkdn / html-to-pdfmake

This module permits to convert HTML to the PDFMake format
https://aymkdn.github.io/html-to-pdfmake/index.html
MIT License
545 stars 88 forks source link

Feature request: support for native Ecma script modules #192

Open Havunen opened 11 months ago

Havunen commented 11 months ago

I'm requesting this module to add support for native ESM modules so it can be loaded in environments where common js is not supported. For example jest native ESM mode.

add "type": "module" to package.json and "exports" entry point

Aymkdn commented 11 months ago

I'm afraid that it will break the module import for many people (including me)… depending on the version of Node and how old your projects are.

I'd have to run some tests, but it's not on my priority list right now, so don't hold your breath!

Havunen commented 11 months ago

What about bumping major version to v3 to indicate the braking change and supporting both v2 and v3 temporarily?

Aymkdn commented 11 months ago

What about bumping major version to v3 to indicate the braking change and supporting both v2 and v3 temporarily?

Yes, but it means more work for me because I'll have to maintain two branches. I'll think about it.