search

Aymkdn / html-to-pdfmake

This module permits to convert HTML to the PDFMake format
https://aymkdn.github.io/html-to-pdfmake/index.html
MIT License
545 stars 88 forks source link

Fix dynamic table widths parsing #207

Closed luicfrr closed 6 months ago

luicfrr commented 6 months ago

This PR will also fix #206

In my tests with TinyMCE text editor and using #206 html code everything is working now as shown on bellow pic:

Captura de Tela 2024-03-04 às 11 23 16

Aymkdn commented 6 months ago

Thanks.

Could you also add some unit tests https://github.com/Aymkdn/html-to-pdfmake/blob/master/test/unit.js ?

luicfrr commented 6 months ago

Ok, I'll add this ASAP

luicfrr commented 6 months ago

@Aymkdn can you please take a look into added test? I added only one test for now but I'll add some more soon.

At this moment I'm a little bussy with other things but I'll open another PR when I have some other testings

Aymkdn commented 6 months ago

I conducted a couple of tests, and everything appears OK to me. While having additional unit tests would be beneficial, having at least one is sufficient for me at this point. :-)

Thank you!