search

Aymkdn / html-to-pdfmake

This module permits to convert HTML to the PDFMake format
https://aymkdn.github.io/html-to-pdfmake/index.html
MIT License
545 stars 88 forks source link

Corrected processing of the rowspan attribute #209

Closed ematochkina closed 6 months ago

ematochkina commented 6 months ago

This change affects the order in which rows are traversed to process the rowspan attribute. I am faced with incorrect formation of row No. 4 of the table: image

After processing cell [1,1] with rowspan=4, the state of row No.4 changes from [{"text": "T4"}] to [{"text": "T4"}, {"text": ""}] because cell [3,0] with rowspan=2 has not been processed yet.

Therefore, I suggest first of all going through the columns of the table.

Aymkdn commented 6 months ago

Thanks for sharing. I'll have a look at it as soon as I have a moment!