search

AyogoHealth / cordova-plugin-update-notifier

Cordova plugin for showing a notification for app updates.
Apache License 2.0
27 stars 10 forks source link

Force iOS update #7

Closed szh closed 3 years ago

szh commented 3 years ago

This could be made into a config.xml option

dpogue commented 3 years ago

Hi @szh, thanks for the pull request!

I had a bit of discussion about this with my team, and we think having a preference in config.xml for how strict to be about updates is probably the best option.

Some points of discussion were around what the default behaviour should be, how to keep iOS and Android behaviour aligned as much as possible, and how to ensure that the preference also works when used in Capacitor.

A good next step would be to add a preference (ForceUpdateInstallation boolean maybe? Feel free to propose something else) and use that to set the Siren mode like you're doing here.

Thanks!

szh commented 3 years ago

@dpogue I agree that's the best way to go. I don't have the time to implement that now but if someone else wants to use my code as a starting point that would be fantastic. In the meantime I'm just going to use my fork since it serves my purposes.

szh commented 3 years ago

Closing in favor of #8