Replace <USE_SERIAL> by <if(Serial) Serial. ...> command

Aypac / Arduino-TR-064-SOAP-Library

Arduino library for the TR-064 protocol, most commonly used by the Fritz!Box router API

Other

63 stars 21 forks source link

Replace <USE_SERIAL> by <if(Serial) Serial. ...> command #13

Closed hasenradball closed 5 years ago

hasenradball commented 5 years ago

This PR includes the following changes:

remove USE_SERIAL and replace it by if (Serial) Serial. ... Therefore the serial output is printed if a Serial Connection is set up by Serial.begin(...), if not the serial output is not printed.
Add some spaces for comments
ensure the compiler runs without errors and warnings

hasenradball commented 5 years ago

PR was tested, it works fine for Serial. Should also work with the , because there the Serial is also included.

Aypac commented 5 years ago

Hi @hasenradball , sorry for not reacting earlier. Unfortunately I had sone deadlines this week. I am very grateful for your PR. I will take a look tonight and probably also merge it then.

Aypac commented 5 years ago

Looks good and runs on ESP32 and 8266. Thank you for the PR :+1:

hasenradball commented 5 years ago

Youre welcome :-)