search

Aypac / Arduino-TR-064-SOAP-Library

Arduino library for the TR-064 protocol, most commonly used by the Fritz!Box router API
Other
65 stars 21 forks source link

Bad Folder Structure when using Arduino IDE #6

Closed hasenradball closed 6 years ago

hasenradball commented 6 years ago

Hi, I tried to use git to add this Library in the Arduino IDE by using the command:

git clone https://github.com/Aypac/Arduino-TR-064-SOAP-Library.git Arduino-TR-SOAP-Library

The cloning was successfull, but the Problem was that during build the Header file tr064.h was not found. The .h and the .cpp has to moved one folder above, so that the IDE could build the file. So please move the files , and the file one folder up and delete the empty folder named "TR-064-SOAP-Library".

Benefit: the the build works directly by using git for clone the repository and the git pull also works for update changes from the repository.

Good example: see: https://github.com/PaulStoffregen/Time Works fine using git clone and git pull, etc...

Thank you!

Aypac commented 6 years ago

Done with 5aed7d4

hasenradball commented 6 years ago

Hi Thank you!

Perfect! One Question regarding the code related to What is the benefit of the #define Use_Serial Serial instead of using directly Serial in the *.cpp file?.

Aypac commented 6 years ago

Hi! My pleasure :)

Thank you for your suggestions! Keep 'em coming!

I honestly don't know. I guess I adopted it from somewhere else. But I have to change that anyways, see #8. If you want to do this, an according pull-request would be very welcome. It might be some time otherwise, before I come around to do this.

hasenradball commented 5 years ago

Hi I proposed some changes see PR #13.