search

Aypac / Arduino-TR-064-SOAP-Library

Arduino library for the TR-064 protocol, most commonly used by the Fritz!Box router API
Other
63 stars 21 forks source link

Is this a typo? In the commit before it has been spelled differently "serviceType" not "sErviceType" ... #64

Closed gremmlinMTW closed 1 year ago

gremmlinMTW commented 1 year ago

https://github.com/Aypac/Arduino-TR-064-SOAP-Library/blob/7469e9ee3e1042e38e2ca86f85c707eda881b4f7/src/tr064.cpp#L128

Aypac commented 1 year ago

Yes, I think this is an old typo resurfacing through the wonders of git merging/cherry-picking. However, it should not matter, because if I remember right, xmlTakeParam reverts to a non-case-sensitive version if the case-sensitive one does not work. I will double-check to be sure.

gremmlinMTW commented 1 year ago

You are right, I saw that just later. Best regards, Roland

René Vollmer @.***> schrieb am Di. 21. Feb. 2023 um 22:22:

Closed #64 https://github.com/Aypac/Arduino-TR-064-SOAP-Library/issues/64 as completed.

— Reply to this email directly, view it on GitHub https://github.com/Aypac/Arduino-TR-064-SOAP-Library/issues/64#event-8575068106, or unsubscribe https://github.com/notifications/unsubscribe-auth/AIYC2OQSTAEIWBSRGVFTFRDWYUWYHANCNFSM6AAAAAAU6UVOL4 . You are receiving this because you authored the thread.Message ID: @.*** com>

Aypac commented 1 year ago

Still fixed it in cbb7223 / release 1.2.3