search

AyuntamientoMadrid / consul

Consul - Gobierno abierto del Ayuntamiento de Madrid
https://decide.madrid.es/
GNU Affero General Public License v3.0
49 stars 15 forks source link

[Security] Bump kaminari from 1.1.1 to 1.2.1 #2096

Open dependabot-preview[bot] opened 4 years ago

dependabot-preview[bot] commented 4 years ago

Bumps kaminari from 1.1.1 to 1.2.1. This update includes a security fix.

Vulnerabilities fixed

Sourced from The GitHub Security Advisory Database.

Cross-Site Scripting in Kaminari

Impact

There was a vulnerability in versions of Kaminari that would allow an attacker to inject arbitrary code into pages with pagination links.

For example, an attacker could craft pagination links that link to other domain or host: https://example.com/posts?page=4&original_script_name=https://another-host.example.com

In addition, an attacker could also craft pagination links that include JavaScript code that runs when a user clicks the link: https://example.com/posts?page=4&original_script_name=javascript:alert(42)%3b//

Releases

The 1.2.1 gem including the patch has already been released. All past released versions are affected by this vulnerability.

Workarounds

Application developers who can't update the gem can workaround by overriding the PARAM_KEY_EXCEPT_LIST constant.

module Kaminari::Helpers
  PARAM_KEY_EXCEPT_LIST = [:authenticity_token, :commit, :utf8, :_method, :script_name, :original_script_name].freeze
end
</tr></table> ... (truncated)

Affected versions: < 1.2.1

Release notes

Sourced from kaminari's releases.

v1.2.0

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

Changelog

Sourced from kaminari's changelog.

1.2.1

Security Fixes:

  • Added original_script_name parameter to the ignore list: #1020 [@viseztrance] See CVE-2020-11082 for full details.

Bug Fixes:

  • Fixed a couple of grouped total_count regressions by reverting #979

1.2.0

Deprecations:

  • Deprecated current_per_page in favor of limit_value

Enhancements:

  • Added #url_to_next_page and #url_to_prev_page helper methods: 38e95a2
  • Extracted url helper methods and packed them in Kaminari::Helpers::UrlHelper: ff38bee
  • Improved performance of total_count for grouped queries by explicitly giving SQL select clause #979 [@MmKolodziej]
  • Added LIMIT to total_count query when max_pages presents #981 [@rymai]

Bug Fixes:

Commits
  • ab8b111 Version 1.2.1
  • 674aeec Merge pull request #1020 from viseztrance/fix/add-entry-to-blacklist
  • 8dd52a1 Blacklist "original_script_name" get param
  • 04d86ed Revert "Merge pull request #979 from MmKolodziej/better_total_count_for_group...
  • 7347292 kaminari supports Ruby 2.8 (or 3.0 or whatever comes next) and Rails 6.1
  • a2f262e Actually, let's call it 1.2.0
  • f901ad4 Version 1.1.2
  • c3114fa Changes for version 1.1.2
  • b21c1da using has to be called from the toplevel in Ruby 2.0
  • 795b2b7 Let this plugin internal method be super private within this file
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) - `@dependabot use these labels` will set the current labels as the default for future PRs for this repo and language - `@dependabot use these reviewers` will set the current reviewers as the default for future PRs for this repo and language - `@dependabot use these assignees` will set the current assignees as the default for future PRs for this repo and language - `@dependabot use this milestone` will set the current milestone as the default for future PRs for this repo and language - `@dependabot badge me` will comment on this PR with code to add a "Dependabot enabled" badge to your readme Additionally, you can set the following in your Dependabot [dashboard](https://app.dependabot.com): - Update frequency (including time of day and day of week) - Pull request limits (per update run and/or open at any time) - Automerge options (never/patch/minor, and dev/runtime dependencies) - Out-of-range updates (receive only lockfile updates, if desired) - Security updates (receive only security updates, if desired)