Ayush7614 / Bundli-Frontend

Bundli-Frontend 🚩 is a repo that contains 🚀different code of full stack Development 👨‍💻🚀

MIT License

138 stars 176 forks source link

Added Disney Plus Implementation #791

Closed hariketsheth closed 2 years ago

hariketsheth commented 2 years ago

Description

Fixes #789

Type of change

[x] New feature (non-breaking change which adds functionality)

Checklist:

[x] My code follows the style guidelines(Clean Code) of this project
[x] I have performed a self-review of my own code
[x] I have commented my code, particularly in hard-to-understand areas
[x] I have created a helpful and easy to understand README.md
[x] I have made corresponding changes to the documentation
[x] My changes generate no new warnings
[x] I have added tests/screenshots(if any) that prove my fix is effective or that my feature works

Reference Used

https://www.youtube.com/watch?v=ZeY9RicS2js&t=1s

Screenshots

ghost commented 2 years ago

👇 Click on the image for a new way to code review

- Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=791&src=https%3A%2F%2Fgithub.com%2FAyush7614%2FBundli-Frontend)

Legend

CodeSee Map Legend

hariketsheth commented 2 years ago

@Ayush7614 Please review

hariketsheth commented 2 years ago

@gurjeetsinghvirdee Please review this. No Response from quite some time

gurjeetsinghvirdee commented 2 years ago

Copied from here https://www.youtube.com/watch?v=ZeY9RicS2js&t=1s

hariketsheth commented 2 years ago

Copied from here https://www.youtube.com/watch?v=ZeY9RicS2js&t=1s

But if a person have implemented it, how does that count for Plagiarism. In that case, everyone should be booked for plagiarism for copying the tags and syntax from official documentation of that programming language.

I seriously didn't find this to be a justified action on this particular PR.

hariketsheth commented 2 years ago

Everyone sees tutorials, takes some help, and implements the things. In today's scenario, clone of everything is either available on Youtube as a video or in form of code in some Github repository. Then how does is it fair to count this PR for Plagiarism ?

gurjeetsinghvirdee commented 2 years ago

then mention that you take reference how could we know that you are taking reference