search

AzBuilder / terraform-provider-terrakube

Terraform provider for Terrakube
Apache License 2.0
4 stars 3 forks source link

Add support workspace_vcs resource #44

Closed alfespa17 closed 2 months ago

alfespa17 commented 2 months ago

Fix #41

stanleyz commented 2 months ago

I was wondering whether the existing workspace_cli can be refactored to workspace to support both cli and vcs type and potentially the API-driven workflow, but I am happy enough with this new resource also.

alfespa17 commented 2 months ago

I was wondering whether the existing workspace_cli can be refactored to workspace to support both cli and vcs type and potentially the API-driven workflow, but I am happy enough with this new resource also.

Workspace cli is a special case inside terrakube, I think it is better to have a different resource

stanleyz commented 2 months ago

Just tested this from my local, worked well. Do you mind add Terraform Working Directory as well? Thanks.

alfespa17 commented 2 months ago

Just tested this from my local, worked well. Do you mind add Terraform Working Directory as well? Thanks.

I will create another PR with the working directory, I also need to add the VCS connection so it can be used with private VCS

stanleyz commented 2 months ago

Thanks, and tags for workspaces. I might create two issues for each of these if you haven't. I might pick one for PR.

alfespa17 commented 2 months ago

Thanks, and tags for workspaces. I might create two issues for each of these if you haven't. I might pick one for PR.

If you want to help with the tags all help is welcome