search

AzBuilder / terrakube

Open source IaC Automation and Collaboration Software.
https://docs.terrakube.io
Apache License 2.0
505 stars 40 forks source link

Team permissions and actions visibility #1141

Open seboudry opened 2 months ago

seboudry commented 2 months ago

Feedback

Hi!

Currently when adding a team to a workspace it makes this one available to members of that team (or Dex group).

But, if no manage permissions is granted, all creation/modification buttons/screens are present.

This is weird because users thinks they can do many things and error message popped (or 403 API response just ignored by UI with an infinite wait icon). Furthermore, we dont want to expose organization/workspace settings/variables (and states) to users that don't have manage permissions.

It will be better for user experience to not shows these creation/modification things.

Is this a something possible and may be provided to a future release?

jcanizalez commented 2 months ago

I think this should be a good improvement. @alfespa17 do you remember if there is any existing api endpoint that returns the current user permissions?

alfespa17 commented 2 months ago

I guess you can do a get request to api/v1/organization/organizationid/teams and compare the response with the JWT token inside the UI to show or not some field in the UI

stanleyz commented 2 months ago

also +1 for this one