If You Give A Mouse A Cookie

He's going to ask for a glass of milk... this started out an an audit of where we had not added max power levels to some spells since some of them get so big they can crash servers at max level.

https://github.com/Azami7/Ollivanders2/issues/477

added max/min limits to several spells

https://github.com/Azami7/Ollivanders2/issues/507

moved Incarnatio spells to their right names

https://github.com/Azami7/Ollivanders2/issues/509

Split broom items in to two - basic boom and an enchanted broomstick
made doSmokeEffect on flying default to false
added handling item drop and pick up to Volatus
removed item lore checks (so, legacy items will no longer work)

https://github.com/Azami7/Ollivanders2/issues/498

made Snufflifors work for book items

https://github.com/Azami7/Ollivanders2/issues/476

added getDamageableEntity so that AVADA_KEDAVRA can target Ender Dragon Parts

Break up Ollivanders2Common:

split out entity common functions
split out Time functions
split magic level out
made several functions static since they can be

EntityTransfiguration

setDuration() was never being called
added success check to canTransfigure()
added customizeEntity() so that spells can do things like change the entity age, color, etc
added listeners to kill the spell when the transfigured entity dies
Moved ItemTransfiguration to ItemToItemTransfiguration since this has different code than ItemToEntityTransfiguration
entity allow list is also based on caster skill and level (when years are enabled)
Split item to item and item to entity transfigurations

BlockTransfiguration

simplified canTransfigure() code and added success check

Stationary Spells

added increase and decrease radius functions to ensure min/max radius is enforced by each spell
made spells that change stationary spells only affect shield spells (so not floo, vanishing cabinets, etc)
only do listener actions when spell is active

Magic Level

added magic level checks to spells that affect stationary spells
added checks to spells like finite incantatum and reparifarge that also consider spell level
spells that affect items have to be as or stronger than any enchantments on that item
when Years are enabled, current year affects usesModifier for spells

Pyrotechnia

simplified max fireworks calculations

Fianto Duri

added failure message

ItemEnchantment

updated logic to skip wands and already enchanted items rather than just wands

Lapifors and Lagomorhpa

lapifors is supposed to transfigure both "small objects and entities", split in to two spells
lapifors transfigures items
lagomorpha transfigure small mobs

O2Spell

refactored setUsesModifier so that years can be applied even when maxSpellLevel is turned on

Ollivanders2API

finished changing manager classes back to Ollivanders2 so that a reference to the plugin class is not needed as an arg to the API

Obliviate

refactored this spell to randomize the number of spells and potions and amount of each forgotten

Reparo

added 2nd, higher level, Reparo for handling Diamond and Netherite level items

Herbivicus

cleaned up old cropstate info from pre 1.16 version

Lapido

removed this spell since it is a subset of Duro and not a "real" HP spell

Volatus and Brooms

changed BROOMSTICK to be an unenchanted broom for use with Volatus and added BROOM as a fully enchanted, basic speed, broom

ReduceO2Effect and RemovePotionEffect

changed ReduceO2Effect to remove since it is only used by LIBERACORPUS and that should remove the effect entirely
added a success check based on caster skill and the relative levels of the counter-spell and the effect for RemoveO2Effect

Misc:

code format cleanup on all files
made some class and variable names more descriptive
removed unneeded {} from single-line if-elses where there were likely debug statements before
javadoc cleanup/added missing on all files
made some variables final where they can be
renamed whitelist/blacklist data structures
removed some uses of deprecated tempBlocks list in plugin class

Azami7 / Ollivanders2

If You Give A Mouse A Cookie #510