Localization not working?

[tgstyle]

Not a big issue as it is just your sample anyway. However, in 1.10.2 - 1.3.8, looks like the ring is not rendering.

[tgstyle]

It appears to be localization? None of the names in the mod are working, the ring is missing the texture. 1.3.9 still has the issue. This is at least true for en_US

[SnowShock35]

It seems that 1.3.10 attempted to fix this issue and did not either 😕

[oitsjustjose]

So oddly enough, this problem was fixed for me when I first installed this update, but I just noticed today that it had broken itself again.. not sure what's up, I've restarted my client a few times and the mod version and install locations haven't been changed, so I'm super confused...

Unless one of the mods using Baubles is packaging Baubles with it..?

[Azanor]

I'm trying to figure out why this is happening. Baubles on its own seems to work fine, but the moment other mods get thrown into the mix the localization bugs out. Very strange - it is not like I am doing anything unusual with it or even touched that code.

[oitsjustjose]

I've spent about 2 hours in the dev environment for Baubles and I can't figure it out. I did, however, manage to fix it in a not-so-pretty way.

I wouldn't be surprised if this bug was caused by I18n, but I'm not certain; that being said, it is deprecated so maybe this is the reason why? I honestly can't tell, you're using localizations exactly the same way as I do, and the encoding type of your .lang files is perfectly fine. Running I18n.canTranslate() returns false every time in Baubles, so I'm truly confused, but I use it in my mod and it works just fine.

That being said, this is what I've put together, and it seems to work. With that:

1: I know this isn't formatted how you like, and

2: You've gotta be pretty careful with implementing this since it uses client-side only methods. I can't imagine it being a huge deal, but just always gotta be cautious. But you're a fantastic modder, so you shouldn't have a problem with this.

Side note: ring texture is broken because Ring.json needs to be lowercased to ring.json

EDIT: Even in the dev environment with ONLY Baubles installed, localizations were not working. So it wasn't another mod causing it in my case.

[Xalcon]

just a fyi, i made a pull request to fix the issues for 1.11.2.

[Azanor]

Doh, yeah - the localization files needs to be all lowercase as well. I forgot about that. Thanks for the fix.

[oitsjustjose]

Will this be fixed on 1.10.2? I'm not sure what the issue was there, but it still persists - not that it's a huge deal!

[Azanor]

Oops, was not aware it still occurred in 1.10 as well. Should be a similar fix.

[oitsjustjose]

Hate to be the bearer of bad news, but still no cigar:

This is on 1.3.1.1 - I have no idea what it could be aside from what I could distinguish a few weeks ago.

[SnowShock35]

1.10.2 - Still Broken 1.11.2 - Perfectly fine all working.

[Xalcon]

I guess there was a misunderstanding with my pull-request. Minecraft 1.10.2 still uses the Resourcepack Format v2, which requires lang filenames to be in the format ab_CD. Only v3 (1.11+) wants them to be all lowercase.

I've just tested this in my development environment. If the lang files have said format, the localisation works fine.

Also: the pack.mcmeta is set to version 1. I dont think this causes any issues with localisation in 1.10.2 but it should be version 2.

[SnowShock35]

@Xalcon Oh yeah 😛 so just need to recapitalise the lang files and change pack.mcmeta version to 2

[tofof]

@Azanor ping Confirmed, 1.10.2 needs capitalized format (and should probably be v2).