search

Azanor / thaumcraft-beta

Location for Thaumcraft beta testers to report problems, suggestions and errors.
MIT License
139 stars 103 forks source link

Suggestion to particle engine #1521

Open Zeitheron opened 6 years ago

Zeitheron commented 6 years ago

I've noticed that particles continue to tick even if you press ESC and game pauses. Would be right to pause particles as well. I know that it would be as simple as adding a check with Minecraft.getMinecraft().isGamePaused() check. Because it looks pretty weird that vanilla particles freeze but Thaumcraft ones don't...

Hubry commented 6 years ago

Speaking of inconsistencies with vanilla particles, Thaumcraft particles don't seem to respect the particle settings either, setting particles to Minimal still causes Thaumcraft to spawn many of them.

Tyrion216 commented 6 years ago

On the subject of particles, the particles that come out of the everfull urn are completely spherical and perfectly round. All other water particles from anything are the squares, as it should be in minecraft. The spheres are cool and all but they look so out of place in minecraft in my opinion.

Xobra commented 6 years ago

@Tyrion216 it's Magic! ..errr... Thaumcraft!

But on another note, I noticed fire not stopping too, if pausing the game.

Zeitheron commented 6 years ago

@Xobra I think that Azanor does add fire particles to own engine thus they don't pause as well 🤔