Azanor / thaumcraft-beta

Location for Thaumcraft beta testers to report problems, suggestions and errors.
MIT License
139 stars 103 forks source link

Automated crossbow doesn't work with spectral or custom arrows #1698

Open daedalus4096 opened 5 years ago

daedalus4096 commented 5 years ago

In the course of re-implementing Primal Arrows from TC4/5, I discovered that they don't work with the Automated Crossbow or Advanced Automated Crossbow. Nor do Spectral Arrows. In both cases, the crossbow will cheerfully consume them as ammunition, but what it fires will just be a mundane arrow.

It seems that the crossbow code creates arrows by calling the EntityTippedArrow constructor directly. Instead, if it were to call the ItemArrow#createArrow method on its mainhand held itemstack's item, it should have maximum compatibility with anything that derives from ItemArrow.