search

Azanor / thaumcraft-beta

Location for Thaumcraft beta testers to report problems, suggestions and errors.
MIT License
139 stars 103 forks source link

Taint permanently changes sand to dirt. #607

Open talonos2 opened 6 years ago

talonos2 commented 6 years ago

As reported in https://github.com/Azanor/thaumcraft/issues/1694 (Is that repo even still around?) If you have an area that is tainted and it converts sand into tainted soil, then when it turns back, it becomes dirt instead of reverting to sand. This can cause significant visual artifacts in tainted deserts, beaches, etc. Perhaps we could get a "tainted soil" with a different metadata so that it can revert properly?

You said in the issue linked above that the mechanics of taint were changing in a way that indirectly fixed this, so I thought I'd point out that the issue still exists.

Glad to see you back! Looking forward to working with your mods again!

Mike-U5 commented 6 years ago

I think Azanor is staying away from metadata in preparation for 1.13, but yes making it change back to sand would definitly be nice.
Also the old repo is probably gone since 1.7.10/1.8 versions are no longer being developed.

talonos2 commented 6 years ago

Shows how out-of-date my modding knowledge is. 🙄

Sumguy62 commented 6 years ago

or just add a tainted sand block

Azanor commented 6 years ago

Having tainted soil keep a memory of what it used to be will add quite a bit of complexity to the block that I'm trying to avoid. On the other hand since it is it's own block now and not a subtype as in 1.10 and earlier I could probably store that info a bit easier. Hmmm. I will give this the enhancement tag and maybe revisit it later once this storm of bugs have been solved :p

talonos2 commented 6 years ago

This shows ignorance of taint mechanics, but there are blocks that can't be converted to tainted versions, right? (I tried putting an ME controller a few blocks from a taint seed and it seemed to survive covered in taint fibres for half an hour.)

If that's the case, you could just make sand one of those blocks that doesn't convert. That's what we did in Blightfall to keep the deserts from turning weird once they were cleansed:

https://youtu.be/5GkhUbZAatI?t=687

AnrDaemon commented 6 years ago

IIRC, anything with hadness 10 or higher can't be affected by taint. @Azanor ?

Geethebluesky commented 6 years ago

Sooo... only obsidian, basically? Eep...

AnrDaemon commented 6 years ago

Out of "naturally occuring" blocks, yes.

talonos2 commented 6 years ago

I think it's actually 5 or higher that's resistant to taint.

But besides, taint can only affect blocks that are of the materials "Wood", "Ground", "Grass", "Rock", and a few more of the less-common material types. (At least, in the version I checked.) The ME Controller I mentioned above was safe because its material type was "Iron".