search

Azaret / superputty

Automatically exported from code.google.com/p/superputty
MIT License
0 stars 0 forks source link

Patch - add Icons themes, Folder dragNdrop enabling. #121

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Hi Jim,

As requested, I've supplied a SVN patch for 2 changes I've made recently.

1. Folders are now dragable to other folder. Added this feature due to 
"Imported Sessions" when I tested, I couldn't get rid of that name, so now I 
can drag the imported out into their resting place.
KnownBug : Need still to reorganise your session path stored, in each node 
(will work on this next).

2. Themed icons are now available for each entry dropping files into 
./themes/default/icons and can be set when Adding or Editing. filenames are 
stored with the session so they return when app is restarted.
KnownBug : 'default' theme so far hardcoded until selector available, 'Putty 
Sessions' hardcoded to specific icon name but changeable if file is replaced.

I was hoping you could have an idea on recursively updating the session paths 
so they are recorded properly on save.

I can continue working further on these enhancements but would like you to 
evaluate if it's coming along ok or not as not sure best practice wise if it 
looks sane ;)

George

Original issue reported on code.google.com by djtrem...@gmail.com on 2 Jun 2012 at 5:33

Attachments:

GoogleCodeExporter commented 9 years ago 
thanks.  will take a look.

Original comment by btatey...@gmail.com on 3 Jun 2012 at 3:30

GoogleCodeExporter commented 9 years ago 
it does require some minor work (ie just added for new users to this version 
would default to specific icon as imageKey is null initially on saved session, 
etc).
It' just to show the bulk of 2 patches.

I do need ideas/help on chaning that session.SessionID to the new path as it's 
not storing it correctly yet.

Original comment by djtrem...@gmail.com on 3 Jun 2012 at 3:48

GoogleCodeExporter commented 9 years ago 
hi, i tried to apply the patch and open the project.  It looks like a few files 
that are missing.  Somethings like the files in Resources and ImageListPopup 
are missing.

Could you create another patch with all the files?  

Alternatively, you can just zip up your whole SuperPutty directory (minus the 
bin and obj folders) and post that.

Original comment by btatey...@gmail.com on 11 Jun 2012 at 1:20

GoogleCodeExporter commented 9 years ago 
argh sorry about that, I forgot it added a class to manage the popup image 
selection. that part still needs work to do a total=x*y matrix which is fixed 
atm but works still without it (just limited icons so far).

attached is full zip which includes a running binary in it. The ./themes dir 
needs to exist where the binary runs from so the bin/Debug has that there. we 
could tailor it if needed.

I wanted to do the folders too by since they are dynamic and not stored in the 
sessions as an object, i can't flag them or set my new features for them. maybe 
will add that too later.

Original comment by djtrem...@gmail.com on 11 Jun 2012 at 1:55

Attachments:

GoogleCodeExporter commented 9 years ago

Original comment by djtrem...@gmail.com on 11 Jun 2012 at 2:04

Attachments:

GoogleCodeExporter commented 9 years ago 
took the binary out and some other junk. oops

Original comment by djtrem...@gmail.com on 11 Jun 2012 at 2:05

GoogleCodeExporter commented 9 years ago 
Fixed up code with svn ver 1.2.0.14 and only patch and theme files and 
resources.
Sessions.xml with no images will use default image from resource loaded into 
imagelist

May have to change popup as it's affecting editor form centering on parent if 
you guys want to change for a better method.

Original comment by djtrem...@gmail.com on 19 Jun 2012 at 8:58

Attachments:

GoogleCodeExporter commented 9 years ago 
Sorry, realised I upload a busted patch file.

Original comment by djtrem...@gmail.com on 20 Jun 2012 at 9:17

GoogleCodeExporter commented 9 years ago

Original comment by djtrem...@gmail.com on 20 Jun 2012 at 9:17

Attachments:

GoogleCodeExporter commented 9 years ago 
Is it worth me porting a cleaned up working version of the icon functions into 
1.3?
I'd like to make a theme dir with default and others can add their own icon 
folder names which SP would pick up and load based on preferences but would 
require quite some additions to preferences section and my last patch wasn't 
included.

Original comment by djtrem...@gmail.com on 7 Aug 2012 at 3:26

GoogleCodeExporter commented 9 years ago

Original comment by btatey...@gmail.com on 26 Aug 2012 at 1:58