AzeemIdrisi / InstaLoaderApp

Instagram Bulk Media Downloader for Android based on instaloader
GNU General Public License v3.0
60 stars 18 forks source link

Add ScrollView to Main Screen UI #6

Closed noobshubham closed 12 months ago

noobshubham commented 1 year ago
AzeemIdrisi commented 1 year ago

You are trying to solve a non-existing problem. I just rechecked the current version, and it has no issues moving the cursor back and forth around the entered text, even if it is pretty long.

Thank you for making an effort to make this app better, but this change does not solve any problems.

noobshubham commented 1 year ago

Actually description and title got wrong, I was trying to solve the page scrollable while entering the username. And everything is right

On Wed, Oct 4, 2023, 9:03 PM Azeem Idrisi @.***> wrote:

You are trying to solve a non-existing problem. I just rechecked the current version, and it has no issues moving the cursor back and forth around the entered text, even if it is pretty long.

Thank you for making an effort to make this app better, but this change does not solve any problems.

— Reply to this email directly, view it on GitHub https://github.com/AzeemIdrisi/InstaLoaderApp/pull/6#issuecomment-1747049564, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANI4GAUBHF2AVLUNUY7A5RDX5V6UVAVCNFSM6AAAAAA5SOU37SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGA2DSNJWGQ . You are receiving this because you authored the thread.Message ID: @.***>

AzeemIdrisi commented 1 year ago

Okay, Now this makes sense. I'll test the app by building from your code and then merge the pull request.

noobshubham commented 1 year ago

Okay, fine!

On Wed, Oct 4, 2023, 9:53 PM Azeem Idrisi @.***> wrote:

Okay, Now this makes sense. I'll test the app by building from your code and then merge the pull request.

— Reply to this email directly, view it on GitHub https://github.com/AzeemIdrisi/InstaLoaderApp/pull/6#issuecomment-1747246145, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANI4GAXE5YDTLJVSSWAOEZLX5WERVAVCNFSM6AAAAAA5SOU37SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBXGI2DMMJUGU . You are receiving this because you authored the thread.Message ID: @.***>

AzeemIdrisi commented 1 year ago

Great work, The app looks better now. Thank you for making this contribution. Do you want hacktoberfest-accepted label?

noobshubham commented 1 year ago

Yes, I wanted the label. Thanks.

On Wed, Oct 4, 2023, 10:36 PM Azeem Idrisi @.***> wrote:

@.**** requested changes on this pull request.

Remove this commit.

— Reply to this email directly, view it on GitHub https://github.com/AzeemIdrisi/InstaLoaderApp/pull/6#pullrequestreview-1658110979, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANI4GATI3HQZQA3MFQPI373X5WJQDAVCNFSM6AAAAAA5SOU37SVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTMNJYGEYTAOJXHE . You are receiving this because you were mentioned.Message ID: @.***>

AzeemIdrisi commented 1 year ago

@noobshubham Update?

noobshubham commented 1 year ago

Yes, it's done. Thanks!

On Thu, Oct 5, 2023, 7:37 PM Azeem Idrisi @.***> wrote:

@noobshubham https://github.com/noobshubham Update?

— Reply to this email directly, view it on GitHub https://github.com/AzeemIdrisi/InstaLoaderApp/pull/6#issuecomment-1748976240, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANI4GAQYSR2MLVXOCWQSTJDX525KBAVCNFSM6AAAAAA5SOU37SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYHE3TMMRUGA . You are receiving this because you were mentioned.Message ID: @.***>

noobshubham commented 1 year ago

Hey sorry man, I wasn't able to delete that local setup today. I'll surely do it by tomorrow and let you know. Thanks.

On Thu, Oct 5, 2023, 11:56 PM Noob Shubham @.***> wrote:

Yes, it's done. Thanks!

On Thu, Oct 5, 2023, 7:37 PM Azeem Idrisi @.***> wrote:

@noobshubham https://github.com/noobshubham Update?

— Reply to this email directly, view it on GitHub https://github.com/AzeemIdrisi/InstaLoaderApp/pull/6#issuecomment-1748976240, or unsubscribe https://github.com/notifications/unsubscribe-auth/ANI4GAQYSR2MLVXOCWQSTJDX525KBAVCNFSM6AAAAAA5SOU37SVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONBYHE3TMMRUGA . You are receiving this because you were mentioned.Message ID: @.***>

noobshubham commented 12 months ago

@noobshubham I want you to delete the u: Local Chaquopy Setup commit from the pull request leaving only the main change in the pull request.

Can you please help me with the command, I don't understand what should I use like revert or rebase.

AzeemIdrisi commented 12 months ago

Try this : https://stackoverflow.com/a/51400593

noobshubham commented 12 months ago

Try this : https://stackoverflow.com/a/51400593

Done, Thanks Alot.