'rename' action cannot contain whitespaces

Azelphur / PokemonGo-CalcyIV-Renamer

Uses adb to send fake tap events to your phone, alongside Calcy IV to automatically rename all your pokemon.

GNU General Public License v3.0

77 stars 32 forks source link

'rename' action cannot contain whitespaces #15

Closed esauvisky closed 5 years ago

esauvisky commented 5 years ago

I think 'input text' is probably interpreting more than one word as different parameters. Also, input text does not allow most special characters, which to be honest are quite handy for sorting pokémons.

I think the best solution for both problems is to use clipper on the opposite way, using the set intent:

adb shell am broadcast -a clipper.set -e text {rename_string}

Azelphur commented 5 years ago

I agree, using clipboard will also be faster too - I'll get that done soon.

esauvisky commented 5 years ago

I've already done it, PR in a moment

esauvisky commented 5 years ago

Jeez, that took me ages...

Apparently I really have no idea how to work with remote upstream repos. At the very least I managed to get this one out :smile: Still figuring out how to keep a different local/origin state (I'm not quitting my unicode normalization! :grin: ) and have git not to include those changes in every PR...

Azelphur commented 5 years ago

Cool, I've accepted the pull request, so I'm gonna go ahead and close this one.