Closed esauvisky closed 5 years ago
Hmm, I'm not sure I'm a fan of this, it converts ① to 1, so the regex would not match if someone had used ① in the regex (which they would do, this seems counterintuitive)
It would also break if a user had used the custom symbols option? I don't think there's a need to normalize the unicode.
That log is very weird, because when RE_CALCY_IV matches, it returns and stops reading logcat, it would then need to rerun the intent (which it hasn't yet) in order to get an invalid scan that has no values.
While checking the existence of name does work around the issue, something else is going on here. Although I'm not sure what, can you reproduce this with the latest version?
Sorry, the regex thing has nothing to do with this issue. I actually made a mess on my repo, never played too much with doing merge requests to upstream repos, so I'm trying to figure it out how to keep personal changes away – like that regex thing –, which belongs to the other issue I opened.
This might have something to do with Island, I don't remember if the app was running on the Island or not. I also had to add a --user argument to the renamer so I could pass the intents to the sandboxed apps. Do you have any interest on that feature? I think it's quite a niche case.. hehe
@esauvisky Ah, I was wondering what the --user thing was. I'm perfectly happy for that as a feature, perhaps add it to args with a helptext explaining it's for island/.. and default it to unset - job done
Any chance you could add me on discord (Azelphur#9918) I feel like we'd get more done if we could chat :)
for now gonna close this one.
I fixed it like so, but I might be completely mistaken and doing something wrong.
Take a quick look at it and tell me if this makes sense or if is this a PEBCAK :grin: