search

Azelphur / PokemonGo-CalcyIV-Renamer

Uses adb to send fake tap events to your phone, alongside Calcy IV to automatically rename all your pokemon.
GNU General Public License v3.0
77 stars 32 forks source link

Adds suport for using other users CalcyIV instances using arg '--user' #43

Closed esauvisky closed 4 years ago

esauvisky commented 5 years ago

Allows to target instances of CalcyIV ran by other users of the device (i.e.: a cloned version of CalcyIV running from a Work Profile, as with Island).

The changes in pokemonlib.py required for this PR were already merged long time ago alongside the "change everything to use clipper" migration, specifically on this commit

Azelphur commented 5 years ago

Does this work fine if you don't specify --user and have a normal, single pogo setup? it seems it would pass --user 0, which I'm guessing is a default?

esauvisky commented 5 years ago

Yes, user zero is the default user, at least on all devices I've ever seen.

Even though, you brought a good point. The best alternative would be to avoid passing the argument at all to am if you don't pass the --user option to the script, just like it works currently. After all we never know what cell phone manufacturers might do..., there might be a device out there with a different default user.

I don't remember if it's trivial, but I'll see if I can do it and update the PR. Maybe @claytono can take a look as well, he's the one that asked for this PR :stuck_out_tongue: