Azeroth-Pilot-Reloaded / azeroth-pilot-reloaded

Azeroth Pilot Reloaded
GNU General Public License v3.0
29 stars 10 forks source link

Switch CTRL modifier key to ALL modifier key #114

Closed Neogeekmo closed 1 year ago

Neogeekmo commented 1 year ago

Switch IsControlKeyDown (ctrl left/right) to IsModifierKeyDown (ctrl/alt/shift)

Neogeekmo commented 1 year ago

currently we only take into account the CTRL key as modifier key because we used the IsControlKeyDown function (which takes into account the left and right ctrl) But the api has another function IsModifierKeyDown which by default listens on ctrl, alt and shift (left and right for all) what makes that people can use the modifiers that they want as wow allows

NightofStarrs commented 1 year ago

I would look more into using something like _MODIFIER_STATE_CHANGED_, https://wowpedia.fandom.com/wiki/MODIFIER_STATE_CHANGED -- that way, it grabs a single attribute of L & R CTRL, SHIFT, and ALT.

Instead, the default example given is: IsModifierKeyDown() == IsControlKeyDown() or IsShiftKeyDown() or IsAltKeyDown() IsControlKeyDown() == IsLeftControlKeyDown() or IsRightControlKeyDown()

That way, it should be able to be customized at a later time with v3?

Neogeekmo commented 1 year ago

MODIFIER_STATE_CHANGED is an event that is triggered when we click on a modifier key but in the end it's up to us to recode the IsModifierKeyDown() function. The example just says that IsModifierKeyDown is just the function that takes everything.

What we can do in V3 is to put in the settings a dropdown menu to choose the modifier they want

Neogeekmo commented 1 year ago

this PR is just because I want to be able to use ALT and not CTRL with my alts because that's my default modifier is ALT for me xD