search

Azgaar / Armoria

Heraldry generator and editor
https://azgaar.github.io/Armoria
280 stars 30 forks source link

Support two or three tinctures for some charges #105

Closed Blipz closed 1 year ago

Azgaar commented 1 year ago

Hello. It looks great. Will need some time to check

Blipz commented 1 year ago

Some charges with hardcoded colors (like castle, crown2...) could be added to this, if needed.

Also, the changes to SVG files are minimal (adding class to elements and splitting paths) but ideally, I'd like to modify some of them a bit more, like the dragon ones to make the scales on their belly use the secondary tincture.

Azgaar commented 1 year ago

I believe all charges that can be multi-colored should support multiple colors. Otherwise it looks weird. But on auto-generation it should come pretty rarely. Maybe we can define multi-color probability in config.

And yes, some of svg will have to be changed.

Azgaar commented 1 year ago

@Blipz, any other work expected here? I mean for this particular Pull Request.

Blipz commented 1 year ago

I think I'm done here, unless maybe for the wingSword charge where I don't know if we should use a (hardcoded) carnation tincture for the hand, or keep it of the same color as the wing.

Azgaar commented 1 year ago

Checked the code, it looks there is some work to be done, started as https://github.com/Azgaar/Armoria/tree/multicolor2

Azgaar commented 1 year ago

@Blipz, please merge my changes to your branch here: https://github.com/Blipz/Armoria/pull/1. Then I will merge this PR