search

Azgaar / Armoria

Heraldry generator and editor
https://azgaar.github.io/Armoria
272 stars 30 forks source link

Make all charges patternable #124

Closed Blipz closed 1 year ago

Azgaar commented 1 year ago

Hello. Looks good, but it's a big change. Would need to change Map Generator and Armoria API accordingly. As we change charges data here, it would make sense to add positions to the new object as well.

Blipz commented 1 year ago

Do you mean the default position when a charge is added?

Azgaar commented 1 year ago

Yes, list of positions

Blipz commented 1 year ago

Sorry, I'm not following. Currently, what are the charges that should not be placed in the center of the shield by default?

Azgaar commented 1 year ago

In dataModel there is a positions object that can be refactored. Data can be added to Charges and Ordinaries data

Azgaar commented 1 year ago

Sorry for being unclear, I have work in parallel, trying to do 10 things at the same time

Blipz commented 1 year ago

I did miss this part of the code. That's done now, as well as the natural tincture part.

Azgaar commented 1 year ago

Not sure I can review before the weekend. Also would need to do the same in FMG and API.

Azgaar commented 1 year ago

Started to work on it yesterday, but my macbook has died, so it will take more time now...

Blipz commented 1 year ago

Started to work on it yesterday, but my macbook has died, so it will take more time now...

Oh, hope you did not lose important stuff... No rush here, I will work on something else.

Blipz commented 1 year ago

The wolfStatant charge has to be adapted, too.