Azgaar / Armoria

Heraldry generator and editor
https://azgaar.github.io/Armoria
280 stars 30 forks source link

Ordinaries missing Variations #165

Open ChevronTango opened 4 months ago

ChevronTango commented 4 months ago

Many of the Ordinaries, like the Chevrons or the Bordures, are missing the options to embattle or cotise them. Whilst the pale and fess has these options, they should be extended to the rest of the ordinaries as well.

Azgaar commented 4 months ago

These are just technical limitations

Blipz commented 4 months ago

I tried implementing a potenty bordure once (using SVG masks and stroke-dasharray) and the results were not great, especially in the corners. My conclusion was that this would need defining a different path for each shield shape and for each variation (so way too much work).

ChevronTango commented 4 months ago

Does that preclude the chevrons and other ordinaries from having those aswell?

I'd also add, is it worth cotising being a separate parameter? Those can be a different tincture to the ordinary itself, and can often be a different varient too (eg. An embattled chevron, with normal cotise, and vice versa).

Azgaar commented 4 months ago

It does not, but it's hard to do and require a lot of time to implement. It's an open source project, so you can implement this feature on your own and make it available for others.

Blipz commented 4 months ago

Here is an example of issues with bordure when trying to do it the "simple way":

Similarly, this might look weird for chevrons at the angle points. For anyone wanting to try it, the following can be done:

ChevronTango commented 4 months ago

I actually don't think that looks too bad. Granted, it's not perfect, but I've honestly seen real rendering that look far worse than this.

I've not looked at the code, so don't know how the rendering on each edge works, but you might be able to make a few simple tweaks, like offsets to the pattern and the start and end , or the scale on eaxh edge so they arent uniform, to tidy it up a bit. Honestly I think that looks fine though, especially considering we don't have any options right now to do it.

Similarly, this might look weird for chevrons at the angle points. For anyone wanting to try it, the following can be done:

I might give it a play when I get a free moment. Could be fun.

Azgaar commented 4 months ago

simple tweaks

These simple tweaks and not simple at all