SvelteKit migration - Githubissues

Azgaar / Armoria

Heraldry generator and editor

https://azgaar.github.io/Armoria

272 stars 30 forks source link

SvelteKit migration #169

Closed Blipz closed 1 month ago

Blipz commented 1 month ago

Regarding the Armoria API integration:

Image compression was not ported, as it's unclear to me what is the best way to handle it
API endpoints were kept as is, but I wonder if it's useful to keep both /format/size/seed and ?format=&size=&seed= (for now I redirected the former to the latter, which may not be ideal)
Claiming API could not be fully tested with a real MongoDB database

Azgaar commented 1 month ago

Hi @Blipz, I suggest to merge it to another branch, not master, and deploy it from there. I will allow us to see how it works before switching from the current version. I hope I can work on it this weekend.

Blipz commented 1 month ago

OK, will push in sveltekit branch.

Azgaar commented 1 month ago

Hi @Blipz, can you please resolve the conflicts so that we can merge it to the branch?

Blipz commented 1 month ago

These changes are already merged in the sveltekit branch. The PR can be closed unless we want to keep it for discussing the topic.

Azgaar commented 1 month ago

Ok, makes sense. Let's close it and then raise a new one if required.