Unreadable state labels when generated from biome layer

[basxto]

Describe the bug

When generating new maps with biomes view, state labels become unreadable. It doesn’t look like it really has to be “Biomes map”, but that “Labels” layer not being active during generation. On first sight it looks like the character width of curved labels got calculated wrong since straight burg labels look fine.

The labels can be fixed with a click on label regeneration.

Steps to reproduce

1. Select “Layer preset” “Biomes map”
2. Generate a “New Map!”
3. Switch to “Layer preset” “Political map”

Expected behavior

Readable state names

.map file

Givraia 2024-03-04-18-34.map.zip

Screenshots

System

• Version: 1.96.2
• Browser: Firefox 121.0.1
• OS: Archlinux

[Azgaar]

It seems to be Firefox-specific issue, looking into it

[basxto]

No, ec5e44b94a86a6a713416642d97805253d2743fc (1.96.03) also fixed this issue. It works now.

[Azgaar]

I can still see the issue in FF

[basxto]

For 1.96.03? I tested in my still open 1.96.02 tab, where it indeed still occurs, and the new 1.96.03, where it doesn’t even though I’m doing the same actions.

[Azgaar]

Should be fine now. The Labels layer rendering was dependent on layer visibility in Firefox and labels size calculation was incorrect. Now it should be fine