search

Azgaar / Fantasy-Map-Generator

Web application generating interactive and highly customizable maps
https://azgaar.github.io/Fantasy-Map-Generator
Other
4.48k stars 636 forks source link

SOURCE CODE: Villages hard-coded to not pass `name` value in URL #1063

Closed buttonpushertv closed 5 months ago

buttonpushertv commented 5 months ago

While looking at the source code for FMG, I see that in modules/ui/editors.js, on line 403 the name value is hard-coded to only ever be a null value. See below:

url.search = new URLSearchParams({pop, name: "", seed: burgSeed, width, height, tags});

Steps to reproduce See the code in modules/ui/editors.js - line 403

Expected behavior Should the name value be passed via the generated URL to Watabou's Village Generator from the current village/burg?

url.search = new URLSearchParams({pop, name, seed: burgSeed, width, height, tags});
DeuzeksMcKinna commented 5 months ago

Intended behavior, the village generator would display the name in a big obstructive font in the small window otherwise.

Azgaar commented 5 months ago

Yes, @DeuzeksMcKinna is right. I had to remove the name to look a least acceptable

buttonpushertv commented 5 months ago

I see. Thanks for the response.