search

Azgaar / Fantasy-Map-Generator

Web application generating interactive and highly customizable maps
https://azgaar.github.io/Fantasy-Map-Generator
Other
4.61k stars 662 forks source link

added icon-dot-circled to locate burg in burg editor menu #1123

Closed Avengium closed 2 months ago

Avengium commented 2 months ago

Description

This is an idea to put a button to "find" or locate where is the burg in the map, on the "Burg editor" menu.

Sometimes you open the edit burg menu, but later you don't know where the burg is. You can try searching for the burg scrolling through the map or open the "burgs overview" to click on "zoom into view" but your burg editor menu is going to be closed.

You can have the "zoom" icon in the same menu burg editor. Near to the relocate button.

In this idea, there are two functions zoomIntoBurg(), one in burgs-overview.js and one in burg-editor.js

Type of change

Versioning

I didn't change the version number. This number could change meanwhile I wait for this idea to be accepted or declined.

netlify[bot] commented 2 months ago

Deploy Preview for afmg ready!

Name Link
Latest commit 140f3f2c9e4714841d3490738697229e3db782a5
Latest deploy log https://app.netlify.com/sites/afmg/deploys/66d788fa8ce86d0008b9213a
Deploy Preview https://deploy-preview-1123--afmg.netlify.app
Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Azgaar commented 2 months ago

What about having this icon to locate (target):

image

And change the relocate icon (that is currently using this icon) to a pin:

image
Avengium commented 2 months ago

I think the icons icon-dot-circled and icon-target are different enough and we could go with that, but we can change them if you want. I initially chose icon-dot-circled because it is the same one used in burg overview and people identify the same icon.

Good idea with pack.burgs[id].x and y. That way the map always centers on the actual burg location, regardless of where its label might be positioned.

Azgaar commented 2 months ago

Please update the minor version and update the import hash.

Azgaar commented 2 months ago

Need to update the version here as well:

image

I have do it myself, it's easy, but I want you to know the whole process for the future :)

Avengium commented 2 months ago

Where is that place on the image? I edited on index.html line 8077.