search

Azgaar / Fantasy-Map-Generator

Web application generating interactive and highly customizable maps
https://azgaar.github.io/Fantasy-Map-Generator
Other
4.58k stars 655 forks source link

Submap Biome generation #1151

Open CASALK opened 2 weeks ago

CASALK commented 2 weeks ago

I was going to create a small submap to represent a mirrored version of the world I had already made, but the map regenerated the biomes and precipitation. Despite what the message before committing to the submap stating, the biomes and precipitation would be copied, which did not happen. This is going from Mamou map to Matei map.

Steps to reproduce

  1. Open the Mamou map, and zoom into the Gateway marker near the top of the Swangulfian empire(the big one on the left).
  2. Zoom in just enough to get the two lakes on the right side, that the Gateway is about in the center.
  3. Only turn on biome layer. And then go to tools, and click submap. Use the base checkmarks.

The expectation is that the submap would just be a mini version of what I had on the main map, biomes and precipitation included.

.map file Mamou 2024-10-10-21-30.zip Matei 2024-10-10-22-05.zip

Screenshots Screenshot 2024-10-10 222209 Screenshot 2024-10-10 222140

System

goteguru commented 2 weeks ago

Confirmed. Submap do NOT copy biomes. It actually regenerates biome data, in order to get better biome resolution. Biome type is calculated deterministically based on temperature and perception. (At least that was the case in previous version of AFMG).

It seems the real problem is that the temperature import has some kind of bug. I'll check it.

Azgaar commented 2 weeks ago

I will do some changes in the function description and also working on some refactoring. Let me know if you have some changes, it would be nice to avoid conflicts :)

goteguru commented 2 weeks ago

No change yet, still trying to identify the root of the problem. I can not replicate the issue with newly generated maps. The problem is with that specific map (Mamou). It seems the cell data got corrupted somehow.

If I simply do "submap" on the whole map (ie. remapping it 1:1) the temperature map changes completely. Strange.

@CASALK additional info about the history of the map would be welcome (transformations, possible prior submaps and/or original version, export/import)

Azgaar commented 2 weeks ago
Azgaar commented 2 weeks ago

Current changes from my side are significant, but I just started to look at the core resampling process, I've never analysed this code in details before :)

goteguru commented 2 weeks ago

Ah, ok. Which one is the stable branch? (the one azgaar.github.io is running on)? Is it the master? I can't see the 'converting map position on the planet' part...

Azgaar commented 2 weeks ago

The current is master. Here is the link to this part: https://github.com/Azgaar/Fantasy-Map-Generator/blob/master/modules/ui/submap.js#L240

CASALK commented 1 week ago

@goteguru Thanks for taking a look! The older map (Mamou), I made on Feburary 12, 2023. Ive been updating it as I've reshaped the lore and states around to best fit what I want. I still have every version of map that I made, I've only made one other submap, which does copy the biome and temperature properly. I can share that file once I have access to my desktop. The biggest changes I've only made were to states and such, nothing touching biome or temperature. Nothing with elevation either.

CASALK commented 1 week ago

Monia 2024-09-19-22-55.zip

Here is the other submap I have made, which was made in early-mid September. The biomes match the location of the original.

Azgaar commented 1 day ago

Working on it