search

Azgaar / Fantasy-Map-Generator

Web application generating interactive and highly customizable maps
https://azgaar.github.io/Fantasy-Map-Generator
Other
4.57k stars 651 forks source link

Rivers generate without regard for other features #456

Closed kaelcarp closed 4 years ago

kaelcarp commented 4 years ago

Description

My final river-related submission.

Rivers seem to generate without regard for lakes, and sometimes for other rivers. See the image. Note the river passing right through a large lake. It is then intersected by another river that runs across it. As a bonus, the other river leads nowhere. There is also a river (a tributary of the first one) that seems to flow into and out of the same lake. bugreport5

Steps to reproduce

Generate a map with lakes. More often than not, at least some of the rivers flow right through the lakes like they aren't there. Interestingly, if you delete those rivers and then use "add river" to add new ones, very often they will correctly account for the lakes and flow into them.

Expected behaviour

Rivers should either terminate at lakes or flow around them.

Actual behaviour

Rivers flow through lakes like they aren't there.

.map file

Rando May13 09-54.zip

Generator version

1.3 Desktop

Browser version

1.3 Desktop in Windows

Azgaar commented 4 years ago

Lake generation that is based on actual water flow is a way to complex to be done within milliseconds. So I just remove small lakes, resolve depressions and calculate water flow without worrying about lakes. Then lakes are restored as they were. That's how it works and I don't know how to make it better and still fast (within 1 iteration). So there is no fix

kaelcarp commented 4 years ago

Understood - thanks for addressing all my reports so fast - this is truly an amazing tool, and I've spent the last few days unable to resist playing around with it!

CanisArtorus commented 3 years ago

Assigning a height to the lake feature as a whole (during resolveDepressions, to replace elevateLakes) seems to be doing quite well. Other than the visual width and name / identity of the outflow river, I've got a PR ready for this.

It costs an extra 0.114 sec (above 1.464 sec) in Firefox 84.0.2 to generate a new Pangea map (mean of 8).

Azgaar commented 3 years ago

I will be interesting to check